Add RPC errors metric #6919
Merged
Add RPC errors metric #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This metric has two labels : RPC method and RPC error type. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
macfarla
approved these changes
Apr 9, 2024
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* Add RPC errors metric. This metric has two labels : RPC method and RPC error type. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Spotless. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Add changelog. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> --------- Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
amsmota
pushed a commit
to Citi/besu
that referenced
this pull request
Apr 16, 2024
* Add RPC errors metric. This metric has two labels : RPC method and RPC error type. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Spotless. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Add changelog. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> --------- Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: amsmota <antonio.mota@citi.com>
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Apr 26, 2024
* Add RPC errors metric. This metric has two labels : RPC method and RPC error type. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Spotless. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Add changelog. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> --------- Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
matthew1001
pushed a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* Add RPC errors metric. This metric has two labels : RPC method and RPC error type. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Spotless. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Add changelog. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> --------- Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add RPC errors metric to Besu. The metric should be labeled with the method RPC name and the error type.
I simulated two errors on eth_call and we can see below the metrics retrieved by prometheus
Fixed Issue(s)
https://github.com/Consensys/protocol-misc/issues/925
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests