Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tx effective gas price when comparing with min mineable gas price… #6958

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Apr 16, 2024

… configuration

PR description

This is a followup of #6611 and correctly use the tx effective gas price when considering if a tx willing to pay at least the min mineable gas price, this because in case of base fee market txs, even if the maxFeePerGas is higher than the minGasPrice, if the baseFee for the next block, is lower than minGasPrice, then the effective gas price, that is the baseFee + maxPriorityFeePerGas could be still lower than the minGasPrice and so the tx could not be included in a block, and so should not be kept in the prioritized layer.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

… configuration

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review April 16, 2024 17:18
@macfarla macfarla enabled auto-merge (squash) April 16, 2024 23:02
@macfarla macfarla merged commit 02754e8 into hyperledger:main Apr 16, 2024
42 checks passed
macfarla added a commit to macfarla/besu that referenced this pull request Apr 26, 2024
… configuration (hyperledger#6958)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
… configuration (hyperledger#6958)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
@fab-10 fab-10 deleted the txpool-min-fee-options-aware3 branch July 23, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants