Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC2 plus fixes #7002

Closed
wants to merge 12 commits into from
Closed

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Apr 26, 2024

PR description

cherry-picks for #6981 and #6806
on top of RC2
plus workflow changes
including #6990

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

matkt and others added 9 commits April 26, 2024 14:51
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
…uilder as it's no longer needed

Signed-off-by: Jason Frame <jason.frame@consensys.net>
…ync/snapsync/CompleteTaskStep.java

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jasonwframe@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@macfarla macfarla changed the title Ws halt on rc2 RC2 plus fixes Apr 26, 2024
macfarla and others added 3 commits April 26, 2024 15:49
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Disable IPv6 in docker container for goss_wait test

Since docker 26.0.0, IPv6 is used by default but our goss_wait test is expecting ports to be exposed on IPv4.
Disabling IPv6 should work for all docker versions
---------

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by:  Usman Saleem <usman@usmans.info>
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla
Copy link
Contributor Author

macfarla commented May 8, 2024

closing this since we have moved on from RC2

@macfarla macfarla closed this May 8, 2024
@macfarla macfarla deleted the ws-halt-on-rc2 branch July 12, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants