BFT ignore withdrawals #7115
Merged
BFT ignore withdrawals #7115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
8 tasks
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
May 28, 2024
* Don't perform validation of withdrawals in BFT chains Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Spotless Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove withdrawal unit test - not applicable any more Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001
added a commit
to kaleido-io/besu
that referenced
this pull request
Jun 7, 2024
* Don't perform validation of withdrawals in BFT chains Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Spotless Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove withdrawal unit test - not applicable any more Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Jun 10, 2024
* Don't perform validation of withdrawals in BFT chains Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Spotless Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Remove withdrawal unit test - not applicable any more Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Short version:
Skips validation of
withdrawalswhen importing BFT blocks since withdrawals don't apply to BFT chainsLong version:
Unfortunately the original shanghai PR #6353 which was included in
24.3.0had a bug that caused blockwithdrawalsto be set incorrectly for newshanghaiblocks. Withdrawals are not applicable to BFT chains, but the block header still has awithdrawalsfield which is validated whenever a block is imported.I fixed the issue in PR #6765 which was released in
24.5.1. However, any chain withshanghaienabled in24.3.0will have already created incorrect blocks, which24.5.1will now fail to import as the validation is now correct - but the created blocks are not.Without requiring users to restore to a point before
24.3.0blocks were produced, I think the most pragmatic approach is to disable withdrawal validation on BFT blocks.Fixed Issue(s)
Fixes #7036