Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recursion from confirmPivotBlockHeader #7126

Closed

Conversation

macfarla
Copy link
Contributor

PR description

Remove recursion from confirmPivotBlockHeader in order to simplify.

Fixed Issue(s)

fixes #7109

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

looks like the simplest thing is not entirely working -
Screenshot 2024-05-22 at 9 07 37 AM

@macfarla macfarla marked this pull request as draft May 21, 2024 23:09
@macfarla
Copy link
Contributor Author

Actually the full burn-in looks much the same as current RC
Screenshot 2024-05-23 at 8 39 45 AM

@macfarla
Copy link
Contributor Author

closing this since we are going with an alternative approach

@macfarla macfarla closed this Jun 10, 2024
@jflo jflo mentioned this pull request Jun 13, 2024
8 tasks
@macfarla macfarla deleted the confirm-pivot-block-recursion branch September 16, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not confirm best peer had pivot block
1 participant