Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote option - bonsai-limit-trie-logs-enabled and bonsai-trie-logs-pruning-window-size #7192

Merged

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jun 7, 2024

Create --bonsai-limit-trie-logs-enabled as alias of --Xbonsai-limit-trie-logs-enabled and unhide option
Same for bonsai-trie-logs-pruning-window-size

Remove --bonsai-historical-block-limit=512 from minimalist_staker profile so it inherits the default which is the same value

Follow on from #7181
Will restructure code from Unstable -> Stable in next PR.

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

…--Xbonsai-limit-trie-logs-enabled

Also bonsai-trie-logs-pruning-window-size

Remove --bonsai-historical-block-limit=512 from minimalist_staker profile so it inherits the default which is the same value
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 7, 2024
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
…ges in changelog

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
@siladu siladu merged commit bfada7d into hyperledger:main Jun 7, 2024
40 checks passed
@siladu siladu deleted the promote-option-bonsai-limit-trie-logs-enabled branch June 7, 2024 13:24
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 19, 2024
gtebrean pushed a commit to gtebrean/besu that referenced this pull request Jun 26, 2024
…indow-size options (hyperledger#7192)

Promote option: create --bonsai-limit-trie-logs-enabled as alias of --Xbonsai-limit-trie-logs-enabled and unhide.
Also bonsai-trie-logs-pruning-window-size.
Remove --bonsai-historical-block-limit=512 from minimalist_staker profile so it inherits the default which is the same value

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: George Tebrean <george@web3labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants