Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for eth_maxPriorityFeePerGasPrice #7194

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Conversation

krsh24
Copy link
Contributor

@krsh24 krsh24 commented Jun 9, 2024

PR description

Fixed Issue(s)

fixes #5658

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: krishnannarayanan <krsh24@gmail.com>
Signed-off-by: krishnannarayanan <krsh24@gmail.com>
Signed-off-by: krishnannarayanan <krsh24@gmail.com>
Signed-off-by: krishnannarayanan <krsh24@gmail.com>
@krsh24
Copy link
Contributor Author

krsh24 commented Jun 9, 2024

Evidence of testing on the Sepolia network.

image

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution, just add a CHANGELOG entry for it.

@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 10, 2024
Signed-off-by: krishnannarayanan <krsh24@gmail.com>
@krsh24
Copy link
Contributor Author

krsh24 commented Jun 10, 2024

LGTM. Thanks for the contribution, just add a CHANGELOG entry for it.

@fab-10 made changes to CHANGELOG. Also added a bug fix in the change log since my previous PR was merged. Thank you.

@fab-10 fab-10 changed the title Support for eth_maxPriorityFeePerGasPrice [#5658] Support for eth_maxPriorityFeePerGasPrice Jun 10, 2024
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added doc-changed-required label and linked to related issue

@fab-10 fab-10 enabled auto-merge (squash) June 10, 2024 16:38
@fab-10 fab-10 merged commit 478b6d0 into hyperledger:main Jun 11, 2024
40 checks passed
@joaniefromtheblock joaniefromtheblock removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support eth_maxPriorityFeePerGas
5 participants