Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maintained PoA bootnode connections configurable #7313

Closed
wants to merge 3 commits into from

Conversation

matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Jul 12, 2024

PR description

This PR follows on from #7257. Specifically it makes the behaviour configurable and defaults to off. Since the 25.7.0 release has just gone out this PR will technically be a change in behaviour, so I'll add a change log entry accordingly. However, assuming this PR is included in an upcoming release I don't imagine any users will be affected by the behaviour change.

In an enterprise network with a large number of nodes, maintaining connections to the bootnodes could be problematic for the bootnodes. Defaulting the behaviour to off avoids the need to specifically disable the behaviour on all of the nodes, but allows a smaller chain to be configured to still treat bootnodes like static nodes.

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

matthew1001 and others added 3 commits July 12, 2024 16:52
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
@matthew1001 matthew1001 changed the title Make maintained POA bootnode conns configurable Make maintained PoA bootnode conns configurable Jul 12, 2024
@matthew1001 matthew1001 changed the title Make maintained PoA bootnode conns configurable Make maintained PoA bootnode connections configurable Jul 12, 2024
@matthew1001 matthew1001 marked this pull request as ready for review July 15, 2024 09:19
@matthew1001
Copy link
Contributor Author

After discussion with @pinges we've decided to close this and revert #7257 (the latter has gone into 24.7.0 so will need a breaking change entry). #7314 provides the behaviour change that is most important - namely that bootnodes can be retried during peer table refresh - so that PR will merge pending approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant