7288: include WithdrawalRequestPredeployAddress in genesis configuration #7356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
siladu
approved these changes
Jul 22, 2024
...src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/WithdrawalRequestProcessor.java
Outdated
Show resolved
Hide resolved
|
@macfarla Do you think we should have the same for Consolidation requests since we have it for deposits and withdrawals? |
macfarla
reviewed
Jul 26, 2024
config/src/main/java/org/hyperledger/besu/config/JsonGenesisConfigOptions.java
Outdated
Show resolved
Hide resolved
config/src/main/java/org/hyperledger/besu/config/JsonGenesisConfigOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…ntractAddress Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
siladu
reviewed
Jul 29, 2024
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
|
Good catch, thanks Simon. I didn't think of that |
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…ion (hyperledger#7356) * 7288: include WithdrawalRequestPredeployAddress in genesis configuration Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7288: Update changelog Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7288: Fix typo in new variable Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7288: Rename withdrawalRequestPredeployAddress to withdrawalRequestContractAddress Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 7288: Update changelog to match recent changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * 5098: Move changelog item to next release Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Allow configuration of WithdrawalRequestPredeployAddress in genesis configuration
Fixed Issue(s)
#7288
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests