Penalize invalid transient pending transactions in the layered transaction pool #7359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR improve the layered txpool, avoiding that invalid transient* pending txs will be continuously evaluated for block inclusion, potentially preventing the evaluation of other valid pending txs that rank behind the former one.
The goal is simple, just penalize invalid transient pending txs, pushing then down in the rank, after all the other, so they will have a chance to be evaluated, but only after all the non-penalized, or less penalized, pending txs have been evaluated.
To achieve this, the
PendingTransaction
now has a score, that start with the max value (127) and it is decremented on every penalization, and that score is now taken in consideration when sorting pending transaction in the layers.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests