Precompile calls were not traced when insuficient gas #7462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pinto
force-pushed
the
fix-precompile-out-of-gas-not-traced
branch
3 times, most recently
from
8b2f1b4 to
b4eb8df
Compare
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
fix-precompile-out-of-gas-not-traced
branch
from
b4eb8df to
98c472e
Compare
shemnon
approved these changes
Aug 14, 2024
| @@ -38,7 +38,7 @@ public class StateDiffGenerator { | |||
| public Stream<Trace> generateStateDiff(final TransactionTrace transactionTrace) { | |||
| final List<TraceFrame> traceFrames = transactionTrace.getTraceFrames(); | |||
| if (traceFrames.isEmpty()) { | |||
| return Stream.empty(); | |||
| throw new RuntimeException("expected to have at least one processed frame"); | |||
There was a problem hiding this comment.
This change in behavior is not essential to the precompile trace fix. Please consider moving it to one of the other RPC PRs.
revert RuntimeException in StateDiffGenerator Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
* Precompile calls were not traced when insuficient gas Signed-off-by: Luis Pinto <luis.pinto@consensys.net> * fixup! Precompile calls were not traced when insuficient gas revert RuntimeException in StateDiffGenerator Signed-off-by: Luis Pinto <luis.pinto@consensys.net> --------- Signed-off-by: Luis Pinto <luis.pinto@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This fixes a tracing problem while replaying a transaction that executes a precompiled contract but it runs out of gas. We were getting an empty
TraceFramearray back from the tracer because the halt condition was never traced.Fixed Issue(s)
fixes #7318
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests