Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly release txpool save and restore lock in case of exceptions #7473

Merged

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 16, 2024

PR description

The disk access lock used when saving or restoring the txpool from disk, was not released in case of an exception, with the effect of stalling the sync

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the fix-release-disk-access-lock-on-tx-restore branch from 4cbb5ff to 72a8409 Compare August 16, 2024 10:20
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will move the changelog entry into release-next

@garyschulte garyschulte enabled auto-merge (squash) August 16, 2024 19:45
@garyschulte garyschulte merged commit 12576d7 into hyperledger:main Aug 16, 2024
40 checks passed
@fab-10 fab-10 deleted the fix-release-disk-access-lock-on-tx-restore branch August 19, 2024 08:19
cloudspores pushed a commit to cloudspores/besu that referenced this pull request Aug 23, 2024
…yperledger#7473)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Ade Lucas <ade.lucas@consensys.net>
gconnect pushed a commit to gconnect/besu that referenced this pull request Aug 26, 2024
…yperledger#7473)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants