Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include current chain head block when computing eth_maxPriorityFeePerGas #7485

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 19, 2024

PR description

Include current chain head block when computing eth_maxPriorityFeePerGas and move the calculation of the lower bound to BlockchainQueries::gasPriorityFee to uniform the code to gasPrice

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the improve-eth_maxPriorityFeePerGas branch 2 times, most recently from 7bd9e1d to ca60b4a Compare August 19, 2024 17:17
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the improve-eth_maxPriorityFeePerGas branch from ca60b4a to 56d6a47 Compare August 19, 2024 17:45
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 marked this pull request as ready for review August 20, 2024 08:43
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) September 2, 2024 09:50
@fab-10 fab-10 merged commit e1dd400 into hyperledger:main Sep 2, 2024
40 checks passed
@fab-10 fab-10 deleted the improve-eth_maxPriorityFeePerGas branch September 2, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants