-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor SimpleWorld to use Optional for storing accounts and extra null checks #7532
Merged
matkt
merged 1 commit into
hyperledger:main
from
lu-pinto:simple-world-commit-add-null-check
Sep 2, 2024
Merged
refactor SimpleWorld to use Optional for storing accounts and extra null checks #7532
matkt
merged 1 commit into
hyperledger:main
from
lu-pinto:simple-world-commit-add-null-check
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
2 times, most recently
from
August 28, 2024 16:18
c95a75b
to
483d772
Compare
shemnon
reviewed
Aug 28, 2024
evm/src/main/java/org/hyperledger/besu/evm/fluent/SimpleWorld.java
Outdated
Show resolved
Hide resolved
garyschulte
reviewed
Aug 28, 2024
garyschulte
reviewed
Aug 28, 2024
garyschulte
reviewed
Aug 28, 2024
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
August 29, 2024 01:16
483d772
to
1e26c71
Compare
lu-pinto
commented
Aug 29, 2024
garyschulte
approved these changes
Aug 29, 2024
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
August 30, 2024 15:46
d16ccc8
to
ae29100
Compare
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
August 30, 2024 16:27
ae29100
to
631ee4b
Compare
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
3 times, most recently
from
September 2, 2024 09:16
de2fced
to
15e126d
Compare
auto-merge was automatically disabled
September 2, 2024 09:43
Head branch was pushed to by a user without write access
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
September 2, 2024 09:43
15e126d
to
eb186c4
Compare
…ull checks Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
simple-world-commit-add-null-check
branch
from
September 2, 2024 10:15
eb186c4
to
1a39d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix several NPEs in
SimpleWorld
and I also decided to useOptional
for accounts since the return fromget
/getAccount
was ambiguous between an account that has been deleted or has never existed. Now there's a clear distinction between deleted (Optional.empty()
) or has never existed (null
). AlsogetTouchedAccounts
returned null values when there were deleted accounts within which can be dangerous to the caller.Note:
SimpleWorld
seems to only be used by the test framework, so this is not critical.Fixed Issue(s)
fixes #7524
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests