Change test to tease NPEs during DefaultBlockchain.<init>() caused by initilization order #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pinto
force-pushed
the
add-test-for-NPEs-due-to-init-order
branch
from
ddd5b0e to
4d53a01
Compare
lu-pinto
force-pushed
the
add-test-for-NPEs-due-to-init-order
branch
from
4d53a01 to
3e6da91
Compare
garyschulte
approved these changes
Sep 11, 2024
Comment on lines
+150
to
+164
| gasUsedCounter = | ||
| metricsSystem.createCounter( | ||
| BesuMetricCategory.BLOCKCHAIN, "chain_head_gas_used_counter", "Counter for Gas used"); | ||
|
|
||
| numberOfTransactionsCounter = | ||
| metricsSystem.createCounter( | ||
| BesuMetricCategory.BLOCKCHAIN, | ||
| "chain_head_transaction_count_counter", | ||
| "Counter for the number of transactions"); |
There was a problem hiding this comment.
Seem to me it would be tidier to have these in the createGauges() (perhaps rename createMetrics()) method or similar, and declutter the constructor.
There was a problem hiding this comment.
Or have another method, createCounters if we want to separate Counters from Gauges ;)
There was a problem hiding this comment.
sure, I think I didn't put those in a method because I would have to drop the final qualifier from the fields.
But I'll go with @ahamlat's suggestion and create another method for counters
ahamlat
approved these changes
Sep 12, 2024
ethereum/core/src/test/java/org/hyperledger/besu/ethereum/chain/DefaultBlockchainTest.java
Show resolved
Hide resolved
Comment on lines
+150
to
+164
| gasUsedCounter = | ||
| metricsSystem.createCounter( | ||
| BesuMetricCategory.BLOCKCHAIN, "chain_head_gas_used_counter", "Counter for Gas used"); | ||
|
|
||
| numberOfTransactionsCounter = | ||
| metricsSystem.createCounter( | ||
| BesuMetricCategory.BLOCKCHAIN, | ||
| "chain_head_transaction_count_counter", | ||
| "Counter for the number of transactions"); |
There was a problem hiding this comment.
Or have another method, createCounters if we want to separate Counters from Gauges ;)
… initilization order Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
…used by initilization order move counters into their own method Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
lu-pinto
force-pushed
the
add-test-for-NPEs-due-to-init-order
branch
from
12c254d to
ab90a1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This complements PR #7601 to make sure possible NPEs are checked during unit tests around
DefaultBlockchainwhen the right order of initialization is not followed.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests