-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and publish Besu BOM (Bill of Materials) #7615
Conversation
96d094a
to
66c0b1c
Compare
This looks clean, but could you provide a description and motivation for the change? |
Thanks @garyschulte, I just forgot to add it, done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just couple of questions...
Does this PR have any impact on the license report?
Lines 113 to 114 in 0d63955
// If set to true, then all boms will be excluded from the report | |
excludeBoms = true |
I have checked and the licenses are checked and the report is produced as before. |
cfcb1ea
to
b07c7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for answering my questions
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
PR description
Introducing Besu BOM (bill of materials) to improve the way we manage shared dependencies between Besu and plugins.
It is based on Gradle Java Platform plugin and it is also used internally, replacing the Spring Dependency Manager, it is then published as BOM artifacts so it can be used as reference in plugins for all the dependencies that are in common with Besu, this way it is easier to spot dependencies incompatibilities when developing plugins.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests