Simplifying BesuCommand step 1 #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jflo
commented
Sep 26, 2024
jflo
commented
- pulls out P2P settings into its own options, and produces a record for downstream users to use, agnostic of picocli. this will eventually be moved alltogether into the relevant subsystem module.
- same for EngineRPC, since it re-uses some of those settings.
- moves DataStorageOptions up from the stable package since it also contains unstable options.
- puts P2PTLSOptions in unstable, since it is.
- overloads the JsonRpcConfiguration creation method to allow for no-arg creation.
- intentionally leaves in some TODOs because this is the first of many steps.
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Merged
fab-10
reviewed
Oct 1, 2024
besu/src/main/java/org/hyperledger/besu/components/BesuCommandModule.java
Outdated
Show resolved
Hide resolved
fab-10
reviewed
Oct 1, 2024
There was a problem hiding this comment.
since a lot of code has been moved out of BesuCommand, should also be possible to move some code out of BesuCommandTest
macfarla
approved these changes
Oct 1, 2024
besu/src/test/java/org/hyperledger/besu/cli/CascadingDefaultProviderTest.java
Outdated
Show resolved
Hide resolved
2fehee
pushed a commit
to 2fehee/besu
that referenced
this pull request
Oct 4, 2024
Simplifying BesuCommand --------- Signed-off-by: Justin Florentine <justin+github@florentine.us>Signed-off-by: Chulhee lee <leefehee@naver.com>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.