-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LUKSO Cancun Hardfork #7686
Merged
fab-10
merged 26 commits into
hyperledger:main
from
lukso-network:feat/lukso-cancun-fork
Sep 30, 2024
Merged
feat: LUKSO Cancun Hardfork #7686
fab-10
merged 26 commits into
hyperledger:main
from
lukso-network:feat/lukso-cancun-fork
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
previously requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the DCO, see https://wiki.hyperledger.org/display/BESU/DCO, and add a CHANGELOG entry
Signed-off-by: Wolmin <lamonos123@gmail.com>
I am no longer aligned with the Governance policies and practices of LFDT and resign my position as maintainer. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
* create separate signature class for code delegations as they have different bound checks Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * test if increasing xmx let's failing acceptance test pass Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> * javadoc Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
…7631) * Don't persist IBFT2 proposal blocks, just validate them Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Tidy up changelog Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Matt Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Wolmin <lamonos123@gmail.com>
* Dev mode for short BFT block periods Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactoring Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Fix comment Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Refactor to make BFT block milliseconds an experimental QBFT config option Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> * Update Json BFT config options Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> --------- Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
…r#7655) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
…yperledger#7656) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
…art 2] (hyperledger#7658) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
…dger#7623) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Blue <bluebluesaku@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
* yParity is valid up to 2**256 as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
* remove integration tests related to privacy Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Matthew Whitehead <matthew.whitehead@kaleido.io> Signed-off-by: Wolmin <lamonos123@gmail.com>
* Update entrypoint script for Dockerfile to only switch user if its running as root Signed-off-by: Rafael Matias <rafael@skyle.net> * make root user check at the beginning Signed-off-by: Rafael Matias <rafael@skyle.net> --------- Signed-off-by: Rafael Matias <rafael@skyle.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
…e available (hyperledger#7633) Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
* Include consolidationRequestContract in jsonGenesisConfigOptions Signed-off-by: gconnect <agatevureglory@gmail.com> * Update changelog and ran spotlessApply Signed-off-by: gconnect <agatevureglory@gmail.com> * Rename consolidationRequestPredeployAddress to consolidationRequestContractAddress Signed-off-by: gconnect <agatevureglory@gmail.com> * Create request contract addresses class Signed-off-by: gconnect <agatevureglory@gmail.com> * Update method calls Signed-off-by: gconnect <agatevureglory@gmail.com> * Refactor RequestContractAddresses class and update method calls and test Signed-off-by: gconnect <agatevureglory@gmail.com> --------- Signed-off-by: gconnect <agatevureglory@gmail.com> Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Wolmin <lamonos123@gmail.com>
…ledger#3810) (hyperledger#6965) Implemented support for emptyBlockPeriodSeconds in QBFT (Issue hyperledger#3810) Introduces experimental xemptyblockperiodseconds genesis config option for producing empty blocks at a specific interval independently of the value of the existing blockperiodseconds setting. hyperledger#3810 --------- Signed-off-by: Antonio Mota <antonio.mota@citi.com> Signed-off-by: amsmota <amsmota@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
…on (hyperledger#7679) Signed-off-by: Karim Taam <karim.t2am@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
Set RELEASE_NAME as environment variable for the step Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Wolmin <lamonos123@gmail.com>
Wolmin
force-pushed
the
feat/lukso-cancun-fork
branch
from
September 27, 2024 13:15
616f3c6
to
621157e
Compare
Signed-off-by: Wolmin <lamonos123@gmail.com>
Wolmin
force-pushed
the
feat/lukso-cancun-fork
branch
from
September 27, 2024 14:38
fb68f26
to
a1aa33e
Compare
macfarla
approved these changes
Sep 30, 2024
fab-10
approved these changes
Sep 30, 2024
@Wolmin you'll need to resolve the conflicts before this can be merged - your branch is locked down too so we can't push to it |
Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com>
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The LUKSO Mainnet Dencun Hardfork is scheduled for Wednesday, 20 November 2024 16:20:00 - the cancunTime (1732119595) is calculated to start 5s before Deneb Fork Epoch start time (first slot of 123075 epoch is 3938400, its timestamp is 1732119600).
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests