single Options package #7693
Closed
single Options package #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
…stable and unstable arguments Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
reviewed
Nov 4, 2024
| // This seems to be the only way it works with Picocli. | ||
| // Also many other software use the same negative option scheme for false | ||
| // defaults | ||
| // meaning that it's probably the right way to handle disabling options. |
There was a problem hiding this comment.
this whole comment is not true any more
There was a problem hiding this comment.
wait I am having deja vu - does this need a rebase?
|
This has been open for too long and it's gonna be a pita to rebase. Closing and will re-open a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves all Options into a single package, since each may contain both stable and unstable arguments