#7608: Fix evmtool JSON Error Field to Return Hex String Instead of Long Null #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l String on REVERT Signed-off-by: 7at <itisfor@outlook.com>
|
per https://eips.ethereum.org/EIPS/eip-3155 error is a hex string field, so this would bring besu into alignment with the EIP. |
jflo
approved these changes
Oct 25, 2024
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this pull request
Nov 17, 2024
…l String on REVERT (hyperledger#7774) Signed-off-by: 7at <itisfor@outlook.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Modified the logic in
evmtoolto check if a revert reason is present and convert it to a hex string. Modified revertReason to hex string inEvmToolCommandandEvmToyCommandas well.Fixed Issue(s)
fixes #7608
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests