Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release checklist #7794

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Oct 22, 2024

Following on from the 24.10.0 release #7710

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
.github/ISSUE_TEMPLATE/release-checklist.md Show resolved Hide resolved
- [ ] git tag 24.4.0; git push origin 24.4.0
- [ ] Manually run https://github.com/Consensys/protocols-release-sandbox/actions/workflows/draft-release.yml using `main` branch and `24.4.0` tag
- [ ] Back on besu, using the same git sha as 24.4.0-RC1, create a calver tag for the FULL RELEASE, example format `24.4.0`
- [ ] Manually run https://github.com/hyperledger/besu/actions/workflows/draft-release.yml inputing the FULL RELEASE tag name. Note, this workflow should always be run from `main` branch (this doesn't prevent hotfix tags from being released)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Manually run https://github.com/hyperledger/besu/actions/workflows/draft-release.yml inputing the FULL RELEASE tag name. Note, this workflow should always be run from `main` branch (this doesn't prevent hotfix tags from being released)
- [ ] Manually run https://github.com/hyperledger/besu/actions/workflows/draft-release.yml using `main` branch and `24.4.0` tag ie the FULL RELEASE tag name. Note, this workflow should always be run from `main` branch (this doesn't prevent hotfix tags from being released)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a slight variation of this

Copy link
Contributor

@cdivitotawela cdivitotawela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu enabled auto-merge (squash) October 22, 2024 03:47
@siladu siladu merged commit 73a6042 into hyperledger:main Oct 22, 2024
43 checks passed
@siladu siladu deleted the update-release-checklist branch October 22, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants