Refactoring around MiningParameters #7798
Conversation
...reum/core/src/main/java/org/hyperledger/besu/ethereum/components/ProtocolScheduleModule.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/hyperledger/besu/consensus/common/bft/BaseBftProtocolScheduleBuilder.java
Show resolved
Hide resolved
| @@ -132,7 +132,6 @@ protected ProtocolSchedule createProtocolSchedule() { | |||
| genesisConfigOptions, | |||
| forksSchedule, | |||
| nodeKey, | |||
| privacyParameters, | |||
There was a problem hiding this comment.
it isn't obvious to me why we can use the default privacy parameters here.
There was a problem hiding this comment.
why is it safe to use this constructor which uses default privacy parameters rather than the superclass' privacy parameters which may (or may not) have been set on the CLI. This is strictly an enterprise concern, but it seems like we are breaking clique networks that have privacy enabled here.
ethereum/retesteth/src/main/java/org/hyperledger/besu/ethereum/retesteth/RetestethContext.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/ProtocolScheduleBuilder.java
Show resolved
Hide resolved
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: jflo <justin+github@florentine.us>
jflo
force-pushed
the
daggerMiningParameters3
branch
from
0730c6f
to
4feaf80
Compare
Sorry, my reply must've gotten dropped. The answer is that it was only ever passed in as a hardcoded default. |
This still looks wrong imo. The link you provides is just the alternate create() that doesn't take privacy parameters. ❓ As I see it, BesuCommand is going to set privacy parameters on the controller builder, derived from CLI params. For a clique network, that will be a CliqueBesuControllerBuilder, with the privacy params set by BesuCommand. In CliqueBesuControllerBuilder when we use the ProtocolSchedule.create method (the one with privacy params on 115) the privacy params from BesuCommand are used. But if we use the other create (155), we are discarding the BesuCommand configured privacy params. It looks like the ProtocolScheduleBuilder that is return is indeed creating ProtocolSpec instances with the privacy params - so it isn't like they are being ignored. What am I missing? |
decoupled parent block header from block creators optionalized some fields of ProtocolSchedule constructor, which will allow us to reduce number of constructors later. Refactored JsonBlockImporterTest so it can provide a BesuComponent ProtocolScheduleBuilder optionalizes the default chainid Blocks SubCommand is now Dagger aware Creates but rarely uses ProtocolSpec and ProtocolSchedule modules. Deeper adoption pending. Adds a Coinbase module with fixed values for use in testing. Introduces an EthereumCoreComponent, to be used as a subcomponent of BesuComponent in the future. Introduces a MiningParameters module with common static values used by tests. Removes MiningParameters static constructor. --------- Signed-off-by: Justin Florentine <justin+github@florentine.us> Signed-off-by: jflo <justin+github@florentine.us> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
tested by syncing to the head of ephemery testnet