Test against EngineNewPayloadV4 in EngineNewPayloadV4Test #7837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
siladu
force-pushed
the
engine-api-v4-tests
branch
from
fa302fe
to
0e96638
Compare
jframe
approved these changes
Oct 31, 2024
siladu
changed the title
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this pull request
Nov 17, 2024
…r#7837) Also change "Missing" -> "Unexpected" message when V3 blob params sent to V2 Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method under test was EngineNewPayloadV3 so the passing tests weren't valid 😅
Remove optional maybeRequests from
AbstractEngineNewPayloadTest.setupValidPayload, instead relying on the V4@Override ... createBlockHeaderand@Override ... respmethods to construct a valid V4 request.Also change "Missing" -> "Unexpected" message when V3 blob params sent to V2
More tidy up of this test hierarchy needed, but this unblocks adding tests for EIP-7742