nonce as integer for preloaded contracts #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
macfarla
reviewed
Nov 4, 2024
| @@ -80,7 +80,7 @@ public Stream<GenesisAccount> streamAllocations() { | |||
| final var on = normalizeKeys((ObjectNode) entry.getValue()); | |||
| return new GenesisAccount( | |||
| Address.fromHexString(entry.getKey()), | |||
| JsonUtil.getString(on, "nonce").map(ParserUtils::parseUnsignedLong).orElse(0L), | |||
There was a problem hiding this comment.
would be great to add a test that verifies the desired behaviour.
There was a problem hiding this comment.
@macfarla Sure, I will begin working on it right away.
jflo
approved these changes
Nov 4, 2024
Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com>
macfarla
approved these changes
Nov 4, 2024
JanetMo
pushed a commit
to JanetMo/besu
that referenced
this pull request
Nov 17, 2024
* fixes hyperledger#7749 Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> * tests Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> * spotless format fix Signed-off-by: vaidikcode <vaidikbhardwaj00@gmail.com> --------- Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Marlene Marz <m.marz@kabelmail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaidikcode vaidikbhardwaj00@gmail.com
PR description
Besu can now interpret the nonce as an integer for preloaded contracts. After thoroughly reviewing the issue, it appears that, as discussed in #7749, the main problem was that JsonUtil.getString was not accepting the nonce as an integer. Following that discussion, I modified it to use the JavaUtil.getValueAsString method.
Fixed Issue(s)
fixes #7749
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests