Consolidate all metric collectors into the metrics system #7877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Built on top of #7879[MERGED]This is the first PR of a series to refresh the metrics system, to pay some tech debt, and to migrate to the new Prometheus Java lib to version 1.x, from the current legacy Simpleclient version 0.x.
Along with the upgrade to the new Prometheus lib, these other tasks are planned to refresh the metrics system:
The scope of this first PR is to consolidate all metric collectors in the metrics system, since with the time, something has spilled out of it, in particular RocksDB internal metrics and Guava cache metrics collectors were created outside the metric system, with the assumption to only support Prometheus as backend.
Both those collectors have been moved into the metrics system, and the ability to add custom collectors from outside the metrics system has been removed.
There are no functional changes or fixes in this PR only refactoring, so no support for the refactored collectors have been implemented for OpenTelemetry, since there was no support before, and since the idea is to use Prometheus to provide OpenTelemetry in a future PR.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests