Add support for counter metric with external supplied value #7894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
labelled-supplied-metric
branch
from
5fadbba to
d8ffff4
Compare
jflo
approved these changes
Nov 20, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 22, 2024
…ger#7894) * Add support for counter metric with external supplied value Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> * Update CHANGELOG Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> --------- Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Another PR of the series to upgrade and refresh the metric system.
This time we fix the type of two metrics used in the
MonitoredExecutorsclass, that are counters but were created as gauges, probably since there was no way to create counters with an external supplied value, so this kind of counter has been added, and the concept of metrics with external supplied values has been extended to cover both counters and gauges.Other than for using the correct metric type, this fix is required, because with the following upgrade to Prometheus Java lib 1.x, only counters can have a
_totalsuffix.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests