Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast sync - deprecation warning #7906

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Conversation

macfarla
Copy link
Contributor

PR description

Deprecation messages for FAST sync mode per https://www.lfdecentralizedtrust.org/blog/sunsetting-tessera-and-simplifying-hyperledger-besu

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than fast sync, there are deprecation warnings for miner options and methods, should they go to another PR?

I see that this is built on top of #7905, fine to approve after that is merged

@macfarla macfarla mentioned this pull request Nov 28, 2024
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Contributor Author

macfarla commented Nov 29, 2024

Other than fast sync, there are deprecation warnings for miner options and methods, should they go to another PR?

I see that this is built on top of #7905, fine to approve after that is merged

Thanks @fab-10 all up to date now just needs approval (did not mean to build this PR on top of #7905 - sorry for the confusion!)

@fab-10 fab-10 enabled auto-merge (squash) November 29, 2024 10:04
@fab-10 fab-10 merged commit afd4da1 into hyperledger:main Nov 29, 2024
43 checks passed
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 2, 2024
* fast sync log warnings for deprecation

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* minor text change in changelog

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
@macfarla macfarla deleted the fast-sync-dep branch December 2, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants