Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown MetricsSystem when stopping MetricsService #7958

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 28, 2024

PR description

Shutdown MetricsSystem when stopping MetricsService, so any registered collector is cleaned, that is most useful during acceptance tests.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 enabled auto-merge (squash) November 28, 2024 11:47
@fab-10 fab-10 merged commit 0cbcd91 into hyperledger:main Nov 28, 2024
43 checks passed
@fab-10 fab-10 deleted the shutdown-metrics-system-on-stop branch November 29, 2024 10:02
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 2, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Ameziane H. <ameziane.hamlat@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants