Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

account overrides: parse hex string into nonce long #7999

Merged
merged 3 commits into from
Dec 9, 2024
Merged

account overrides: parse hex string into nonce long #7999

merged 3 commits into from
Dec 9, 2024

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 9, 2024

PR description

Fixed Issue(s)

fixes #7998

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
parse string into nonce long
bb2e7c4 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla changed the title parse hex string into nonce long account overrides: parse hex string into nonce long Dec 9, 2024
@macfarla
changelog entry
296dc1b 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Gabriel-Trintinalia
Gabriel-Trintinalia approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@macfarla macfarla enabled auto-merge (squash) December 9, 2024 01:26
@macfarla macfarla disabled auto-merge December 9, 2024 01:57
@macfarla
24.12.0
cdc8cc5 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) December 9, 2024 02:01
@macfarla macfarla merged commit 4033d3b into hyperledger:main Dec 9, 2024
43 checks passed
@Gabriel-Trintinalia Gabriel-Trintinalia mentioned this pull request Dec 9, 2024
Merged
daniellehrner pushed a commit to daniellehrner/besu that referenced this pull request Dec 18, 2024
@macfarla @daniellehrner
account overrides: parse hex string into nonce long (hyperledger#7999)
87631b5 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@macfarla macfarla deleted the state-overrides-nonce-hex branch December 19, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel-Trintinalia Gabriel-Trintinalia Gabriel-Trintinalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

state overrides - nonce should allow hex
2 participants
@macfarla @Gabriel-Trintinalia