recognize from and to block parameters in eth subscribe #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
shemnon
approved these changes
May 1, 2020
There was a problem hiding this comment.
LGTM. @lucassaldanha may want to take a quick pass to make sure we don't break the new privacy filtering.
shemnon
approved these changes
May 1, 2020
lucassaldanha
approved these changes
May 3, 2020
| .map(blockHash -> blockchain.matchingLogs(blockHash, filter.getLogsQuery())) | ||
| .orElseGet( | ||
| () -> { | ||
| final long fromBlockNumber = filter.getFromBlock().getNumber().orElse(0); |
There was a problem hiding this comment.
I think we should update this to be the headBlockNumber as well. This seems to be the "default" for Geth APIs. And probably update the PrivGetLogs as well.
I'm happy to do this in another PR is you don't wanna mix up with the other changes! :)
https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getlogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Geth sneakily accepts from and to blocks in its websocket log subscriptions parameters. This extends the websocket subscription to be able to take block parameters. That makes us compatible with their implementation and also our http and ws filter parameters align.
Fixed Issue(s)
fixes #654