Fixed bug where a permissioned IBFT2 network starts in stalled state. #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
macfarla
approved these changes
May 21, 2020
There was a problem hiding this comment.
test fails with the first commit and passes with the second commit. This made it easy to check out and verify. Nice work @mark-terry
.../main/java/org/hyperledger/besu/tests/acceptance/dsl/node/configuration/BesuNodeFactory.java
Outdated
Show resolved
Hide resolved
lucassaldanha
approved these changes
May 25, 2020
mark-terry
added a commit
to mark-terry/besu
that referenced
this pull request
May 27, 2020
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Merged
MadelineMurray
added a commit
that referenced
this pull request
May 28, 2020
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 3, 2020
…hyperledger#969) Signed-off-by: Mark Terry <mark.terry@consensys.net> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jun 3, 2020
* Changelog for PR hyperledger#969. Signed-off-by: Mark Terry <mark.terry@consensys.net> * Tweak. Signed-off-by: Mark Terry <mark.terry@consensys.net> Co-authored-by: MadelineMurray <43356962+MadelineMurray@users.noreply.github.com> Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes an issue where a permissioned IBFT2 network is able to start in a stalled state when the bootnode is not a validator.
Fixed Issue(s)
Fixes #528