-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector-quorum): support Quorum v21.x #901
Labels
dependencies
Pull requests that update a dependency file
dependent
enhancement
New feature or request
Quorum
Comments
petermetz
added
enhancement
New feature or request
Quorum
dependencies
Pull requests that update a dependency file
labels
May 3, 2021
⏳ Alright! Looks like we need to wait for some dependencies: 💡 Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 3, 2021
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 4, 2021
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 21, 2021
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 25, 2021
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
May 26, 2021
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
May 27, 2021
Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes #901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
RafaelAPB
pushed a commit
to RafaelAPB/blockchain-integration-framework
that referenced
this issue
Mar 9, 2022
…r-cacti#901 Refactored how tests are named so that we can start having a support matrix backed by tests for each permutation needed. The used Quorum version is encoded in the beginning of the test case file name to make them easy to tell apart in logs. Fixes hyperledger-cacti#901 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
dependent
enhancement
New feature or request
Quorum
Description
Depends on #900
The connector should support Quorum
v21.4.1
.We need actual test coverage and the AIO image updated for said test coverage so that we can credibly claim said support instead of just saying "well it should because I read the release notes of Quorum v21.4.1 for example and nothing struck me as a change that would mess with our connector's ability to work with it".
The new image tag could be
hyperledger/cactus-quorum-v21.4.1-all-in-one-2021-05-03-$SHA[1-7]
https://docs.goquorum.consensys.net/en/stable/HowTo/GetStarted/Wizard/Interacting/
Acceptance Criteria
Specific test case that is locked down to a
v21.4.1
ledger (the AIO image) so that even if we add more things later on, this test remains frozen in time forever verifying the connector againstv21.4.1
. This will be extremely valuable in the long run in catching regressions.Will probably have to make sure an updated version of the Quorum AIO image is published because right now it can only do Quorum 2.3.0 with Tessera 0.10.0 IIRC
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy
The text was updated successfully, but these errors were encountered: