Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for test-logging-tx-observer #1630

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add test for test-logging-tx-observer #1630

wants to merge 2 commits into from
+340 −32

Conversation

tunedev
Copy link
Contributor

@tunedev tunedev commented Sep 11, 2024

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Partially addresses #1606

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

After this PR: Running the tests in caliper-core the listed %stmts in the code coverage report should tally with the below listed

  • caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 100

Before the PR: Running the tests in caliper-core the listed %stmts in the code coverage report the below listed was what was there before

  • caliper-core/lib/worker/tx-observers/logging-tx-observer.js: 0

Automated Tests

What documentation has been provided for this pull request

@tunedev tunedev requested a review from a team as a code owner September 11, 2024 09:26
davidkel
davidkel requested changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, needs a few changes here. It also breaks the build (see the build details in the PR and github actions). Please run the unit and integration tests before submitting the PR to avoid this

packages/caliper-core/lib/worker/tx-observers/tx-observer-dispatch.js Outdated Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/logging-tx-observer.js Outdated Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Outdated Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/logging-tx-observer.js Outdated Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
packages/caliper-core/test/worker/tx-observers/tx-observer-dispatch.js Show resolved Hide resolved
@tunedev
add test for test-logging-tx-observer
be9ebeb 
Signed-off-by: Babatunde Sanusi <swisskid95@gmail.com>
@tunedev
add test for tx-observer-dispatch
02b94a9 
Signed-off-by: Babatunde Sanusi <swisskid95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunedev @davidkel