Update web3 for ethereum sut to 1.2.2 #862
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this one - there's a few PRs with this change in it now, so it is sure to make it's way in - if possible, could you perform the DCO as we cannot merge without it 👍 Out of interest, are the docker-compose changes also required for the BESU integration test? |
|
This change was included in #863 (together with the Besu binding update). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caliper 0.3.1 uses the new Ethereum SUT 1.2.1 adapter, which itself depends on web3 APIs that came became available with web3 1.2.2 such as
eth.getChainId(see web3/web3.js#3147).However, the bind sut command for ethereum:1.2.1 still used to install web3 1.2.0.
This PR fixes the web3 version for the bind command accordingly.