Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both v1 and v2 of docker compose #460

Closed
xichen1 opened this issue Jun 24, 2022 · 1 comment · Fixed by #466
Closed

Support both v1 and v2 of docker compose #460

xichen1 opened this issue Jun 24, 2022 · 1 comment · Fixed by #466
Assignees

Comments

@xichen1
Copy link
Member

xichen1 commented Jun 24, 2022

Currently, the project only supports docker compose v1 docker-compose, while there exists v2 docker compose. Based on this answer, v1 has now been deprecated and most new docker users are using v2.

The users of v2 on Linux may get the following error message when running make start:

docker-compose -f bootup/docker-compose-files/docker-compose-dev.yml up -d --force-recreate --remove-orphans
make[1]: docker-compose: Command not found
make[1]: *** [Makefile:215: start-docker-compose] Error 127

The Makefile can be changed to support both versions of docker compose.

@yeasy
Copy link
Member

yeasy commented Jun 25, 2022

Let's switch to v2 version.

@xichen1 xichen1 self-assigned this Jun 26, 2022
xichen1 added a commit to xichen1/cello that referenced this issue Jul 7, 2022
Add information about Docker Compose Version switch to setup doc.

Close hyperledger#460

Signed-off-by: xichen1 <xichen.pan@gmail.com>
zhuyuanmao pushed a commit that referenced this issue Jul 10, 2022
* [#issue-460] Switch docker composer to v2

Update the following targes in Makefile:
log, logs, start-docker-compose, stop-docker-compose, check-dashboard.

Update the following other files:
build_image/docker/cello-hlf/Dockerfile,
scripts/master_node/build_js.sh,
scripts/master_node/setup.sh,
scripts/worker_node/setup.sh,
scripts/worker_node/setup_worker_node_docker.sh,
src/dashboard/package.json,
tests/postman/test.sh

These files and targets will be tested on a Linux machine.

Signed-off-by: xichen1 <xichen.pan@gmail.com>

* [#issue-460] Fix the incorrect intents.

Fix the incorrect intents in the last commit.

Signed-off-by: xichen1 <xichen.pan@gmail.com>

* [#issue-460] Modify setup doc

Add information about Docker Compose Version switch to setup doc.

Close #460

Signed-off-by: xichen1 <xichen.pan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants