add docker rest api agent #180
Conversation
|
This pull request introduces 8 alerts when merging 05a3ed4 into ae053b6 - view on LGTM.com new alerts:
|
dexhunter
force-pushed
the
wip-docker-rest-api
branch
from
05a3ed4 to
4d0ba69
Compare
|
This pull request introduces 2 alerts when merging 4d0ba69 into ae053b6 - view on LGTM.com new alerts:
|
dexhunter
force-pushed
the
wip-docker-rest-api
branch
from
4d0ba69 to
0d82c0b
Compare
|
|
||
|
|
||
| class NodeStart(Resource): | ||
| def put(self): |
| res['status'] = 'deleted' | ||
| return res | ||
|
|
||
| api.add_resource(QueryNetwork, '/api/v1/query_network') |
There was a problem hiding this comment.
Nodes as the class.
Each operation is as a method.
| @app.route('/api/v1/nodes/<id>', methods=['GET', 'POST']) | ||
| def operate_node(id): | ||
|
|
||
| if request.method == 'POST': |
There was a problem hiding this comment.
Why do we need this special if check?
| try: | ||
| container.stop() | ||
| except: | ||
| res['code'] = 'Fail' |
There was a problem hiding this comment.
If you are using the same code snippet more than once, better wrap into some small method.
dexhunter
force-pushed
the
wip-docker-rest-api
branch
from
0d82c0b to
dc47444
Compare
|
This pull request introduces 7 alerts when merging dc47444 into 24ace07 - view on LGTM.com new alerts:
|
dexhunter
force-pushed
the
wip-docker-rest-api
branch
2 times, most recently
from
20981f0 to
fea705e
Compare
| # same as `docker run -dit yeasy/hyperledge-fabric:2.2.0 -e VARIABLES`` | ||
| container = client.containers.run(request.form.get('img'), request.form.get('cmd'), detach=True, tty=True, stdin_open=True, name=request.form.get('name'), environment=env) | ||
| except: | ||
| res['code'] = 'Fail' |
There was a problem hiding this comment.
Better use const to define the status code.
dexhunter
force-pushed
the
wip-docker-rest-api
branch
2 times, most recently
from
b9bfed3 to
c184c04
Compare
|
@yeasy I have addressed the comments and updated the code base, please help review. Thanks! |
docker agent for api-agent hyperledger#121 * support for node creation, start, stop, restart, deletion * add crypto materials and integration test Signed-off-by: Dixing (Dex) Xu <dixingxu@gmail.com>
dexhunter
force-pushed
the
wip-docker-rest-api
branch
from
c184c04 to
c0b57be
Compare
docker agent for api-agent #121
Signed-off-by: Dixing (Dex) Xu dixingxu@gmail.com