Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix nodejs async for loop examples #657

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Nov 14, 2023

The block event examples do not seem to work and I have never heard of for async. I assume they are supposed to be for await, which is what the fabric samples use here.

@jrasm91 jrasm91 requested a review from a team as a code owner November 14, 2023 14:36
Signed-off-by: Jason Rasmussen <jrasm91@gmail.com>
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction!

@bestbeforetoday bestbeforetoday enabled auto-merge (squash) November 14, 2023 16:51
@bestbeforetoday bestbeforetoday merged commit c48dd77 into hyperledger:main Nov 14, 2023
24 of 26 checks passed
@jrasm91 jrasm91 deleted the chore/network-docs branch November 14, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants