Fix thread safety bug in eventing unit tests #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
unit-test-thread-safety
branch
from
cd93f69
to
fd58fae
Compare
A sequencing error in the test service implementation meant that request message were acknowledged before they had been stored on the received request queue. This introduced a race condition where tests could check for received requests before the receiving thread had processed them. Also update Maven plugins and test dependencies. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
unit-test-thread-safety
branch
from
fd58fae
to
a763ff7
Compare
andrew-coleman
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sequencing error in the test service implementation meant that request message were acknowledged before they had been stored on the received request queue. This introduced a race condition where tests could check for received requests before the receiving thread had processed them.
Also update Maven plugins and test dependencies.
Closes #696