Feature/integrate with cc tools #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Closed
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
39d2366
to
a064eb0
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
munapower
requested changes
Oct 11, 2024
mbrandenburger
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @osamamagdy this is pretty cool! Let's shape it a bit more!
go.mod
Outdated
Comment on lines
26
to
40
| github.com/hyperledger/fabric v2.1.1+incompatible | ||
| github.com/hyperledger/fabric-chaincode-go v0.0.0-20230228194215-b84622ba6a7a | ||
| github.com/hyperledger/fabric-contract-api-go v1.2.1 | ||
| github.com/hyperledger/fabric-protos-go v0.3.0 | ||
| github.com/hyperledger/fabric-samples/asset-transfer-basic/chaincode-go v0.0.0-20230505123407-84f9ba1dc4ec | ||
| github.com/hyperledger/fabric-sdk-go v1.0.1-0.20240123083657-5d6ca326e01b | ||
| github.com/maxbrunsfeld/counterfeiter/v6 v6.6.1 | ||
| github.com/onsi/ginkgo v1.16.5 | ||
| github.com/onsi/ginkgo/v2 v2.11.0 | ||
| github.com/onsi/gomega v1.27.8 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/spf13/cobra v1.7.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| github.com/stretchr/testify v1.9.0 | ||
| golang.org/x/sync v0.5.0 | ||
| golang.org/x/tools v0.14.0 | ||
| google.golang.org/protobuf v1.33.0 | ||
| google.golang.org/protobuf v1.34.1 |
There was a problem hiding this comment.
I suggest to just revert the changes on go.mod and go.sum
There was a problem hiding this comment.
Done and checking...
Comment on lines
+35
to
+39
| cd ~ | ||
| git clone https://github.com/hyperledger-labs/cc-tools-demo.git | ||
| cp -a ~/cc-tools-demo/chaincode/. $FPC_PATH/samples/chaincode/cc-tools-demo/ | ||
| cd $FPC_PATH/samples/chaincode/cc-tools-demo | ||
| ``` |
There was a problem hiding this comment.
Can we just clone directly?
git clone https://github.com/hyperledger-labs/cc-tools-demo.git $FPC_PATH/samples/chaincode/cc-tools-demo
There was a problem hiding this comment.
We don't need the whole cc-tools-demo repo, I only want the chaincode as the repo includes multiple other files
|
|
||
| ``` | ||
|
|
||
| ## Set the needed env vars in the docker-compose file |
There was a problem hiding this comment.
I think this step should come after we explained how to build the chaincode container
There was a problem hiding this comment.
Isn't it better to have it here as these env vars are mentioned in the code?
Comment on lines
+178
to
+180
| Next step is to test the chaincode by invoking transactions, for which you need a basic Fabric network with a channel. | ||
| We will use the test network provided in [`$FPC_PATH/samples/deployment/test-network`](../../deployment/test-network). | ||
| To invoke the chaincode, we will use the `simple-cli` application in [`$FPC_PATH/samples/application/simple-cli-go`](../../pplication/simple-cli-go). |
There was a problem hiding this comment.
don't we use your cool shell script to test?
There was a problem hiding this comment.
Also I don't see where you explain how to use samples/application/cc-demo here?!
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/integrate-with-cc-tools
branch
from
92e4665
to
1ec09a9
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a tutorial on how to integrate with cc-tools project, specially using the cc-tools-demo project
Which issue(s) this PR fixes:
Fixes the LFX mentorship project Hyperledger Fabric CC-Tools Support for Fabric Private Chaincode