Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][FAB-18363] Update Protobuf to 1.4.3 #2185

Closed
wants to merge 13 commits into from
Closed

[WIP][FAB-18363] Update Protobuf to 1.4.3 #2185

wants to merge 13 commits into from

Conversation

lindluni
Copy link
Contributor

@lindluni lindluni commented Dec 2, 2020

Need to sort through the orderer/consensus/etcdraft issues yet and anything that comes out of integration tests as I haven't run them locally yet (doing it now).

Also: Yes, I will squash once I'm done

Brett Logan added 13 commits December 1, 2020 21:12
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
@lindluni lindluni changed the title Protobuf [WIP][FAB-18363] Update Protobuf to 1.4.3 Dec 2, 2020
@lindluni
Copy link
Contributor Author

lindluni commented Dec 3, 2020

Likely blocked due to this: etcd-io/etcd#12398 (comment)

More info here: etcd-io/etcd#12124

@lindluni
Copy link
Contributor Author

lindluni commented Dec 3, 2020

It seems there are two issues at play here:

  1. etcd doesn't support grpc > 1.29
  2. etcd still uses gogo/protobuf which doesn't support the 1.4 protobuf standard
  3. etcd needs to release the 3.5-alpha.0 build to deal with module issues they have (likely won't happen before the end of the year)

This blocks the upgrade of many of our dependencies unless we do some hacky things in our go.mod to pin our deps to a version that etcd doesn't use, and then do a replace on their versions to something they support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant