Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup code masking useful error message #318

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

peterbroadhurst
Copy link
Contributor

After fix in this PR - quickly shows the simple environmental problem with my local setup:

initializing new FireFly stack...
Cleanup from previous error returned: stat /Users/pbroadhurst/.firefly/stacks/dev/docker-compose.yml: no such file or directory
Error: reading image "ghcr.io/hyperledger/firefly:latest": GET https://ghcr.io/token?scope=repository%3Ahyperledger%2Ffirefly%3Apull&service=ghcr.io: DENIED ....

Before fix in this PR - extremely confusing, as it doesn't mention the actual error:

ff init dev --block-period 1 -n quorum --private-transaction-manager tessera -c ethconnect 1 
initializing new FireFly stack...
Error: stat /Users/pbroadhurst/.firefly/stacks/dev/docker-compose.yml: no such file or directory

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EnriqueL8 EnriqueL8 merged commit 56ebc8f into main Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants