Add --nodiscover to Quorum command line #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
commented
Jul 24, 2024
| @@ -236,43 +237,46 @@ func (p *QuorumProvider) DeployFireFlyContract() (*types.ContractDeploymentResul | |||
| return p.connector.DeployContract(contract, "FireFly", p.stack.Members[0], nil) | |||
| } | |||
|
|
|||
| func (p *QuorumProvider) buildTesseraServiceDefinition(memberIdx int) *docker.ServiceDefinition { | |||
There was a problem hiding this comment.
only moved this out as it was a big block of in-lined code - no functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after starting a Quroum developer environment with the CLI it was attempting to peer with the public list of ethereum nodes.
This PR adds the
--nodiscovercommand line option to stop this.Couple of other minor changes proposes:
tesserato its own directoryEquals(types.PrivateTransactionManagerTessera)for code blocks that are Tessera specific--private-transaction-managerisn't exclusive to Tessera, and this will avoid catching out future contributions that provide other options