Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA-608 Update tezosconnect volumes #321

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

denisandreenko
Copy link
Member

No description provided.

Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
@EnriqueL8
Copy link
Contributor

@denisandreenko a description would be useful here and renaming the PR to what the change is doing.

From what I can see you are splitting out the volumes for the DB from the config that gets mounted from the runtime directory

},
Logging: docker.StandardLogOptions,
Environment: s.EnvironmentVars,
},
VolumeNames: []string{
fmt.Sprintf("tezosconnect_config_%s", member.ID),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this volume? Does it still get created? I do not see code to remove the creation of that volume

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see the code above - we use binding instead of mount for the connector configuration.
It allows us to update the config from the host machine.
We're using the same approach for the evmconnect now as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha

@denisandreenko
Copy link
Member Author

Hey @EnriqueL8
This PR was created in response to this one hyperledger/firefly-tezosconnect#38 to unlock writing operations to the service's DB.
Plus added instant tx receipt check option by default as there is no block processing/ tx filtering functionality like in evm connector.

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the description

@EnriqueL8 EnriqueL8 merged commit a459b82 into hyperledger:main Aug 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants