-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA-608 Update tezosconnect volumes #321
Conversation
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
902c018
to
9268f67
Compare
@denisandreenko a description would be useful here and renaming the PR to what the change is doing. From what I can see you are splitting out the volumes for the DB from the config that gets mounted from the runtime directory |
}, | ||
Logging: docker.StandardLogOptions, | ||
Environment: s.EnvironmentVars, | ||
}, | ||
VolumeNames: []string{ | ||
fmt.Sprintf("tezosconnect_config_%s", member.ID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to this volume? Does it still get created? I do not see code to remove the creation of that volume
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you see the code above - we use binding instead of mount for the connector configuration.
It allows us to update the config from the host machine.
We're using the same approach for the evmconnect now as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha
Hey @EnriqueL8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the description
No description provided.