Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): add new agent derivation path #150

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat(agent): add new agent derivation path #150

merged 1 commit into from
Jul 5, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Jun 20, 2024 •
edited
Loading

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/dependency-path branch 2 times, most recently from 5cf30ef to d66ca6b Compare July 5, 2024 10:48
@goncalo-frade-iohk
feat(agent): add new agent derivation path
0b302f5 
Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/dependency-path branch from d66ca6b to 0b302f5 Compare July 5, 2024 10:48
@coveralls
Copy link

coveralls commented Jul 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9807151893

Details

  • 105 of 138 (76.09%) changed or added relevant lines in 13 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 41.835%
Changes Missing Coverage Covered Lines Changed/Added Lines %
EdgeAgentSDK/Apollo/Sources/Model/Ed25519Key.swift 5 6 83.33%
EdgeAgentSDK/Apollo/Sources/Model/Secp256k1Key.swift 1 2 50.0%
EdgeAgentSDK/Apollo/Sources/Model/X25519Key.swift 5 6 83.33%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+Public.swift 0 3 0.0%
EdgeAgentSDK/Apollo/Sources/Operations/CreateEd25519KeyPairOperation.swift 3 7 42.86%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+KeyRestoration.swift 24 30 80.0%
EdgeAgentSDK/Domain/Sources/Models/KeyManagement/DerivableKey.swift 32 49 65.31%
Files with Coverage Reduction New Missed Lines %
EdgeAgentSDK/Apollo/Sources/ApolloImpl+Public.swift 1 68.83%
EdgeAgentSDK/Apollo/Sources/Operations/CreateEd25519KeyPairOperation.swift 1 48.0%
EdgeAgentSDK/Apollo/Sources/ApolloImpl+KeyRestoration.swift 2 52.5%
Totals Coverage Status
Change from base Build 9807019801: 0.3%
Covered Lines: 4883
Relevant Lines: 11672
💛 - Coveralls

@goncalo-frade-iohk goncalo-frade-iohk merged commit 0b302f5 into main Jul 5, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/dependency-path branch July 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@curtis-h curtis-h Awaiting requested review from curtis-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goncalo-frade-iohk @coveralls @hamada147 @cristianIOHK