Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(castor): add capacity so you can create and resolve prism dids with ed25519 and x25519 keys #158

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Aug 13, 2024

Description:

Add capacity so you can create and resolve prism dids with ed25519 and x25519 keys

Fixes ATL-7160

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@elribonazo
Copy link
Contributor

lgtm, there's some stuff in the pr as u see :) but looks all good!

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/atl-7160 branch 2 times, most recently from 31b162a to 7a1878b Compare August 16, 2024 12:35
…ith ed25519 and x25519 keys

Fixes ATL-7160

Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
@goncalo-frade-iohk goncalo-frade-iohk merged commit 3ec399a into main Aug 16, 2024
3 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/atl-7160 branch August 16, 2024 12:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10420100298

Details

  • 33 of 38 (86.84%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 43.578%

Changes Missing Coverage Covered Lines Changed/Added Lines %
EdgeAgentSDK/Castor/Sources/Operations/CreatePrismDIDOperation.swift 4 5 80.0%
EdgeAgentSDK/EdgeAgent/Sources/EdgeAgent+DIDHigherFucntions.swift 24 25 96.0%
EdgeAgentSDK/Castor/Sources/DID/PrismDID/PrismDIDPublicKey.swift 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
EdgeAgentSDK/Pollux/Sources/Operation/JWT/CreateJWTCredentialRequest.swift 9 14.75%
Totals Coverage Status
Change from base Build 10419984023: -0.03%
Covered Lines: 5093
Relevant Lines: 11687

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants