-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): agent separation of concerns #159
Conversation
c203ade
to
e201eb3
Compare
|
||
public func parseCredential(type: String, credentialPayload: Data, options: [CredentialOperationsOptions]) async throws -> Credential { | ||
switch type { | ||
case "jwt", "", "prism/jwt": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this empty string be here?
case "jwt", "", "prism/jwt": | |
case "jwt", "prism/jwt": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
e201eb3
to
80571a6
Compare
BREAKING CHANGE: This is a refactor, from now on the EdgeAgent will not have any reference with DIDComm and a DIDCommAgent will replace this. EdgeAgent now will scope all the logic that is inherent to it removing any transport layer association, and new agents like DIDCommAgent will scope the EdgeAgent functionalities for a transport layer. With this Pollux also has some significant changes so it is not aggregated to the DIDComm Message. OIDCAgent will take part of OIDC transport layer communication. Signed-off-by: goncalo-frade-iohk <goncalo.frade@iohk.io>
80571a6
to
65ff99d
Compare
Description:
This is a refactor, from now on the EdgeAgent will not have any reference with DIDComm and a DIDCommAgent will replace this.
EdgeAgent now will scope all the logic that is inherent to it removing any transport layer association, and new agents like DIDCommAgent will scope the EdgeAgent functionalities for a transport layer.
With this Pollux also has some significant changes so it is not aggregated to the DIDComm Message.
Checklist: