Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: OIDC and ConnectionlessOffer examples #294

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

curtis-h
Copy link
Contributor

Description:

Adding docs for recent features plus minor fix.

  • fix error in demo app when sending test message

Docs

  • Add Connectionless Offer example
  • fix typos in Connection Presentation example
  • Add OIDC example
  • update index links
  • update sidebar

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h requested a review from elribonazo September 23, 2024 12:22
@curtis-h curtis-h self-assigned this Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Lines Statements Branches Functions
Coverage: 76%
76.29% (3541/4641) 66.4% (1544/2325) 79.98% (855/1069)

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11300303330

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 72.788%

Files with Coverage Reduction New Missed Lines %
src/domain/utils/DER.ts 6 35.14%
Totals Coverage Status
Change from base Build 11287833416: -0.1%
Covered Lines: 3434
Relevant Lines: 4514

💛 - Coveralls

@elribonazo elribonazo force-pushed the docs/oidc_and_connectionless branch from dc70a65 to fd70b48 Compare October 4, 2024 13:21
@chereseeriepa
Copy link
Contributor

Hello @curtis-h - i'm planning to contribute some updates to the connectionless docs soon.

@petevielhaber will you be giving this a review any time soon?

@elribonazo elribonazo force-pushed the docs/oidc_and_connectionless branch from f68072f to c8596f2 Compare October 11, 2024 22:49
@elribonazo
Copy link
Contributor

We can merge this @chereseeriepa as soon as the PR has all the checks passed and branch up to date with main

Signed-off-by: Curtish <ch@curtish.me>
@elribonazo elribonazo force-pushed the docs/oidc_and_connectionless branch from c8596f2 to 480e577 Compare October 11, 2024 22:51
@elribonazo elribonazo merged commit b65fa95 into main Oct 11, 2024
6 checks passed
@elribonazo elribonazo deleted the docs/oidc_and_connectionless branch October 11, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants