Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a PR template #252

Merged
merged 1 commit into from
Mar 8, 2024
Merged

docs: add a PR template #252

merged 1 commit into from
Mar 8, 2024

Conversation

mkbreuningIOHK
Copy link
Contributor

This PR is to add this PR template which is used as below:

Description:

Update the PR template to the one that was agreed by the IO tribe and that will be applicable to all related repositories, this one included.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Mar 8, 2024

Integration Test Results

 5 files  ±0   5 suites  ±0   11s ⏱️ ±0s
17 tests ±0  17 ✅ ±0  0 💤 ±0  0 ❌ ±0 
20 runs  ±0  20 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0fde4d5. ± Comparison against base commit 99199f6.

Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to start this question about the template again.

Checklist almost everything on the checklist could be just text for a new user to read and delete in the template.

@mkbreuningIOHK mkbreuningIOHK merged commit 48eeb5a into main Mar 8, 2024
3 checks passed
@mkbreuningIOHK mkbreuningIOHK deleted the mediator-pr-template branch March 8, 2024 12:33
@mkbreuningIOHK
Copy link
Contributor Author

Let's follow-up on the contribution guideline link to add.

Copy link
Contributor

@petevielhaber petevielhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Minor change recommended

mineme0110 pushed a commit that referenced this pull request Apr 30, 2024
mineme0110 pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>
Signed-off-by: mineme0110 <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
mineme0110 pushed a commit that referenced this pull request May 1, 2024
Signed-off-by: mkbreuning <97112931+mkbreuningIOHK@users.noreply.github.com>

Signed-off-by: Shailesh Patil <shailesh.patil@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants