[refactor]: Remove `ursa` dependency #3422

appetrosyan · 2023-04-25T08:38:24Z

Hyperledger Ursa is rightfully considered EOL. We have no incentive to use ursa over any library given that at this point we're also the only people maintaining it and also the only people using it.

Under these circumstances it is advised to remove the direct dependency on ursa and instead extract the code paths which are used in iroha_crypto. Ursa-specific implementations of cryptographic primitives should be added to iroha_crypto directly.

The text was updated successfully, but these errors were encountered:

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…iroha_crypto types Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…om ursa Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…1305 code from ursa, migrate iroha_p2p to use it Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This also removes bls signature aggregation and rogue key mitigation, as iroha does not and probably will not use aggregated signatures Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This makes all the dependency tree of iroha_crypto wasm-compatible (except `getrandom`, which either requires a "js" feature enabled when used from web, or a custom getrandom implementation in other cases) Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Clean up the API a bit: - hide the implementation details of signatures (they are only used through the PublicKey, PrivateKey and Signature types) - remove even more unused API functions - add missing documentation items Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…iroha_crypto types Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…om ursa Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…1305 code from ursa, migrate iroha_p2p to use it Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This also removes bls signature aggregation and rogue key mitigation, as iroha does not and probably will not use aggregated signatures Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This makes all the dependency tree of iroha_crypto wasm-compatible (except `getrandom`, which either requires a "js" feature enabled when used from web, or a custom getrandom implementation in other cases) Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…nt result.is_ok() checks Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…dency from `iroha_crypto` and introduce configurable tls backends to `iroha_client` openssl-sys was previously added to `iroh_crypto` to allow static builds of openssl with musl libc. This was somewhat a kludge though, as `iroha_crypto` does not depend on `openssl` (or at least it stopped depending on it after removing `ursa` dependency). It was used, however, in the client to allow connecting to iroha nodes via HTTPS. This commit gives the user more freedom in choosing their TLS implementation by providing four features: `tls-native`, `tls-native-vendored`, `tls-rustls-native-roots` and `tls-rustls-webpki-roots`, which mirror corresponding features of `attohttpc` and `tokio-tungstenite`. Unlike previously, none of the TLS implementations are enabled by default, which is a breaking change Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…o types Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…rom ursa, migrate iroha_p2p to use it Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This also removes bls signature aggregation and rogue key mitigation, as iroha does not and probably will not use aggregated signatures Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

This makes all the dependency tree of iroha_crypto wasm-compatible (except `getrandom`, which either requires a "js" feature enabled when used from web, or a custom getrandom implementation in other cases) Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

Clean up the API a bit: - hide the implementation details of signatures (they are only used through the PublicKey, PrivateKey and Signature types) - remove even more unused API functions - add missing documentation items Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…moving dep of iroha_p2p on aead. Also remove buffer-based API from iroha_crypto, it's not used anyways. Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…s_ok() checks Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>

…`iroha_crypto` and introduce configurable tls backends to `iroha_client` openssl-sys was previously added to `iroh_crypto` to allow static builds of openssl with musl libc. This was somewhat a kludge though, as `iroha_crypto` does not depend on `openssl` (or at least it stopped depending on it after removing `ursa` dependency). It was used, however, in the client to allow connecting to iroha nodes via HTTPS. This commit gives the user more freedom in choosing their TLS implementation by providing four features: `tls-native`, `tls-native-vendored`, `tls-rustls-native-roots` and `tls-rustls-webpki-roots`, which mirror corresponding features of `attohttpc` and `tokio-tungstenite`. Unlike previously, none of the TLS implementations are enabled by default, which is a breaking change Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>