Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query validation in no_std #3714

Closed
mversic opened this issue Jul 18, 2023 · 1 comment
Closed

query validation in no_std #3714

mversic opened this issue Jul 18, 2023 · 1 comment
Assignees
@Arjentix @alexstroke1
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Security This issue asks for improved security

Comments

@mversic
Copy link
Contributor

mversic commented Jul 18, 2023 

          Make the `cfg(feature)` external. A no-op verify is dangerous. If we can't do it on `std` it's better to mask the entire function.

Originally posted by @appetrosyan in #3621 (comment)
@appetrosyan appetrosyan self-assigned this Jul 18, 2023
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Security This issue asks for improved security labels Jul 18, 2023
@mversic
Copy link
Contributor Author

mversic commented Dec 7, 2023

maybe the situation is now different with Ursa removed from iroha. Hopefully, we can make signature verification work with no_std

@mversic mversic assigned Arjentix and unassigned appetrosyan Jan 17, 2024
@Arjentix Arjentix mentioned this issue Jan 23, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 8, 2024
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
6fae92a 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix mentioned this issue Feb 8, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 8, 2024
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
6c7cd07 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 8, 2024
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
95cc9bf 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 8, 2024
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
60fc5f1 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 8, 2024
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
533e05f 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit that referenced this issue Feb 12, 2024
@Arjentix
[feature] #3714: Signature validation in no_std (#4270)
8b40e88 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@AlexStroke AlexStroke self-assigned this Feb 26, 2024
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@alexstroke1 alexstroke1

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@appetrosyan @Arjentix @mversic @AlexStroke @alexstroke1